Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

Clicking on calendar causes broken cart update #1152

Closed
@orenyk

Description

@orenyk

Steps to replicate:

  1. Go to equipment model show view (/equipment_models/:id)
  2. Click on any future calendar cell
  3. Cart update "occurs" changing the start date to the date you clicked on, even if it's past the due date
    • I say "occurs" since if you check the request the params pass today and tomorrow as the start and due dates, respectively, and if you go to another page the cart reflects that

      Started PUT "/equipment_models/update_cart" for 127.0.0.1 at 2015-02-16 20:28:18 -0500
      Processing by EquipmentModelsController#update_cart as JS
      Parameters: {"utf8"=>"✓", "page"=>"", "cart"=>{"start_date_cart"=>"2015-02-16", "due_date_cart"=>"2015-02-17"}}
      

Expected: Nothing happens (or cart updates with clicked date as start date and following date (if necessary) as due date)
Actual: Cart start date appears to change to clicked date and due date remains the same

I'm not sure what's going on here; tbh, these actions (and this UI) are going to be rewritten in v6 so unless we feel this is critical we can either just close this or bundle it into there.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions