Missing ToS checkbox fails silently

[orenyk]

This has come up a few times from STC but we thought it was just PEBKAC; turns out there's actually an issue. The check_tos method in ApplicationController is supposed to set the flash if the checkbox wasn't checked off, and the checkout method in ReservationsController is supposed to redirect to :back, but instead it's redirecting to the home page with no flash message.

Verified on both v3.4.9 (Yale-hosted) and v5.2.1 (Heroku-hosted).

[orenyk]

I'm basing this branch off the branch from #416 so I can use the integration test helpers I set up there.

[orenyk]

Ok, figured it out. When we fixed #1185, we used the presence of a flash[:error] to check if we should redirect to the catalog from the manage and upcoming reservation views for banned users. Since that flash was being set in the same request, it appeared in the catalog, but here we're setting the flash in the previous request, going to the manage page, hitting the second redirect, but then the flash is reset so nothing shows up on the catalog. Woo regressions 😢.

I've written an integration test for the ToS checkbox so now it will be caught in the future, fixing it now.

[orenyk]

Done. We now set params[:banned] in the before_action instead and redirect based on that. I also modified it so that superusers aren't redirected; don't see a reason for that to happen. I'm going to back-port to v3.4.x since it was a regression that was introduced in v3.4.9, although I'm not going to port the specs.

[orenyk]

I'm going to wait to issue a PR until #416 is merged since this is blocked on that branch.

[esoterik]

Currently, if the ToS checkbox is checked on check-out, and the check-out fails, the ToS-acceptance still goes through even though the check-out does not. This should be fixed.