Can you ban yourself as a superuser?

[orenyk]

Just occurred to me, not currently on a machine I can test this on. We should test and correct if necessary.

[squidgetx]

You probably can ban yourself. I suppose an easy fix would be to simply disallow it, does anyone see any possible UX issues? You can also demote yourself to an admin, patron etc. anyway though. We might want to add a check to make sure there is always at least 1 superuser account active at any time.

[orenyk]

I can't think of a valid reason to allow a user to ban themselves, and I can definitely see it being done accidentally at some point which could ruin someone's day. I'll quickly add a @user == current_user conditional to the UsersController#ban method and some specs.

[orenyk]

Verified on master, I'll implement the fix.

[orenyk]

Done!