Equipment item notes saved even if checkout fails

[orenyk]

Experienced in v5.2.1 v5.2.2 while playing with our demo app, the equipment item checkout note saves even if checkout fails.

Steps to replicate:

1. Create Reservation for user who hasn't accepted ToS
2. Attempt to check out without checking off the ToS box
3. Visit the relevant Equipment Item page

Expected: No note saved
Actual: Checkout note saved

Shouldn't be too hard to fix, let's get this in v5.3.0

[TyPetrochko]

Just reproduced this, looks like everything else remains correct (i.e. it's status is 'Available') - it's just the note that wrongly appears.

[orenyk]

I'm hopping on this, should be a quick fix.

[orenyk]

Shoot, this is a little more complicated than I expected. Unfortunately, in order to make the equipment item notes, we need information from within the Reservation#checkout method, but we don't want to call the EquipmentItem#make_reservation_notes method there since there are controller checks (e.g. the ToS checkbox) that are causing things to fail. I'm rearranging some of the stuff in the controller action, but ultimately we probably need to refactor the EquipmentItem#make_reservation_notes not to be dependent on the new_notes.

[orenyk]

Ok, I think I figured it all out. It's a little hack-y since we're re-accessing the params hash to get the new notes but we're only calling EquipmentItem#make_reservation_notes after we save the reservation to check out or check in. I'm also updating Reservation#archive to be consistent.

[orenyk]

Done! Issuing PR now.