Archiving a reservation with no reserver fails

[orenyk]

This is an unfortunate bug since it was one of the original reasons we created an archive action to begin with; it's is a consequence of our notes generation in the Reservation#archive method since we currently try to make links for everything. Steps to replicate:

1. Create reservation
2. Manually set reserver: nil
3. Attempt to archive said reservation

Expected: Success
Actual: Failure

We just need to make sure not to call reserver.md_link if reserver == nil.

[squidgetx]

I was just unable to replicate this; the archiving of a reservation with a nil reserver posed no problem ???

[orenyk]

Huh? I just replicated this on master. The issue is that if you try to archive a reservation with a nil reserver, archiving fails, where this would be a prime use for archiving (since there's no way to access a checkin page for such a reservation).

No route matches {:action=>"show", :controller=>"users", :format=>nil, :id=>#<User id: nil, username: "deleted", first_name: "Deleted", last_name: "User", nickname: "", phone: "555-555-5555", email: "deleted.user@invalid.address", affiliation: "Deleted", created_at: nil, updated_at: nil, terms_of_service_accepted: nil, view_mode: "normal", role: "normal", missing_phone: false, encrypted_password: "", reset_password_token: nil, reset_password_sent_at: nil, cas_login: nil, remember_created_at: nil>} missing required keys: [:id]

[orenyk]

All done, unfortunately I couldn't write feature specs since the archive button triggers a JS prompt for an archiving reason and Capybara isn't set up to handle JS. Fixed by modifying User#md_link to return "Deleted User" if there's no id parameter. Ready for review!