Bug with imported users table

[orenyk]

After running a big import for BMEC (see #1271) I ran into an error post-import (v3.4.10). Looks like we're missing our helper somewhere. We should see if this is an issue on master (import new users as banned users using CAS, verify that imported page shows) and fix if necessary.

ActionView::Template::Error (undefined method `make_ban_btn' for #<#<Class:0x0000000899d5b0>:0x00000004d19030>):
    27:     <% end %>
    28:     <% if can? :manage, User %>
    29:       <td><%= link_to "Edit", edit_user_path(user), :class => "btn" %></td>
    30:       <td><%= make_ban_btn(user) %></td>
    31:     <% end %>
    32:     </tr>
    33:   <% end %>
  app/views/users/_table.html.erb:30:in `block in _app_views_users__table_html_erb__2921148102216889050_40002340'
  app/views/users/_table.html.erb:19:in `each'
  app/views/users/_table.html.erb:19:in `_app_views_users__table_html_erb__2921148102216889050_40002340'
  app/views/import_users/imported.html.erb:16:in `_app_views_import_users_imported_html_erb__1810416023315883582_40407360'
  app/controllers/import_users_controller.rb:23:in `import'

[esoterik]

I can't figure out how to reproduce this because I can't seem to create a valid account to log in with when CAS_AUTH is active. I feel like this is very simple and I'm probably just forgetting to do a small step, but if someone could write a quick run down of how to go about this it would be great!

(Also, I'll document the steps as soon as I get it working)

[orenyk]

If you've set CAS_AUTH in your .env file, then re-running rake db:seed fast=true should ask you for your NetID. As long as that's accurate you should be redirected to the CAS login page when trying to log in to your local instance. Let me know if that works!

[esoterik]

okay, I definitely did all of that before, must have done something weird along the way because it works now. thanks!

however, now when I reach the new user page, it doesn't let me accept the TOS and I can't continue...

[orenyk]

You mean the "create user" page after the first login with CAS? You shouldn't be hitting that page if your NetID is already set up for the superuser. Also, a user doesn't accept the ToS until their first reservation is checked out, I don't think. Could you be more specific about where you're getting stuck?

[esoterik]

Here's where I'm getting stuck post-cas login:

There are not any discernible issues, so I'm not sure how to proceed...

I entered my netid, sky3, when prompted during the seed script.

[orenyk]

Did you check the console output for errors?

[esoterik]

okay, I just did that; there's an "Unpermitted parameter: username" error in the output

[orenyk]

Hmmm... that's weird, sounds like a strong params issue. Can you debug in the UsersController to see what's going on? Looks like I might have made that conditional on the CAS environment variable (this is pure conjecture, I don't really remember what I did and I haven't checked the code). Let me know!

[orenyk]

Also, if this turns out to be a fundamental issue with CAS then we'll need to open up a separate issue, but let's look a little deeper into it first.