Heroku rake tasks are broken

[orenyk]

Since we're calling rake tasks within rake tasks and some of our rake tasks return using guard clauses, we end up with a LocalJumpError: unexpected return. We should fix our tasks according to this SO comment (probably write methods for each separately from the task definitions).

[orenyk]

This is at least a problem with delete_old_blackouts.

[esoterik]

All of the tasks that check conditions in order to run, aside from delete_old_blackouts, use an unless or if block to check conditions instead of a return (e.g. delete_missed_reservations). Should I make all of the tasks that have this behavior use methods separate from the task? Or should the return in delete_old_blackouts be changed to an unless block?

[orenyk]

Based on the SO thread, it seems like the former would be a cleaner solution - separate methods with return so that we could use the guard clause syntax that rubocop prefers, e.g.

def foo
  return if bar
  return unless baz
  [do stuff here]
end

[esoterik]

okay, sounds good

[esoterik]

should I also add tests for tasks that don't have them?

[orenyk]

Yes, please!

[esoterik]

when looking at / writing tests for mailman.rake, I noticed that they're in a namespace like the flag tasks used to be. Should I change this, as in #1273?

[orenyk]

Let's just remove namespaces for now, it will help keep things simple and make writing tests easier. How does that sound?

edited to remove over-tired incoherentness

[esoterik]

great!