Refactor Reservation Scopes / Validations

[orenyk]

Let's refactor the ReservationScopes module to use Concerns Query Objects; this will hopefully help address #1097. We'll also try to use Form Objects to clean up the validations and finally rid ourselves of the ReservationScopes and ReservationValidations modules!

[orenyk]

Ok, this is done and appears not to break anything. I'll check and see if that helped with the CodeClimate score and open a PR if it does.

[orenyk]

Damn that didn't help... one option I've seen is to refactor scopes into multiple files (see here), but that seems overly complex. I'll do a bit more research to see if there are any other ways we can fix the scope clutter...

[orenyk]

I don't know if this helps us, necessarily, but this is a great article with some fairly advanced techniques for improving Models.

EDIT Nvm, look at 4 - Extract Query Objects. I think we're on to something...

[orenyk]

Yup, here's some more stuff that might be useful:

1
2

[caseywatts]

+1 to query objects! :D

[caseywatts]

If it would help, I'm happy to talk through the architecture of this :)