Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

Clean up #1271 #1299

Closed
Closed
@orenyk

Description

@orenyk

Due to my trigger-happy fingers, I merged #1297 pre-review. We should do some final tweaks and write specs for both fixes in #1271 (the spaces in headers and the invalid character parsing) to ensure that everything's working as expected. Sorry!

To Do:

  • fix extra spaces in error message
  • double check instructions for spaces in example CSV
  • double check that UTF-8 encoding command is actually happening
  • write specs for both header spaces and UTF-8 invalid character parsing
  • switch checking for whitespace and raising an error with just parsing out any whitespace in the header row

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions