LDAP lookup no longer includes affiliation

[orenyk]

Apparently when I parameterized LDAP I removed the affiliation parameter - perhaps because it's an array (see here)? This isn't trivial to add back in, let's figure out the best way to do it using secrets.yml?

Issues:

• Multiple parameters needed
• Ruby processing for class year method

[orenyk]

I'll tackle this next

[orenyk]

For reference, here's how we were evaluating affiliation in v3.4

affiliation: [result[0][:curriculumshortname],
              result[0][:college],
              result[0][:class]].select{ |s| s.length > 0 }.join(" ")

@caseywatts put together a nice writeup on how Yale's LDAP is set up (from his awesome gem), so we can use that as a guide. One thing I'm considering is allowing the LDAP parameter ENV variables to pass in Ruby code and executing it (instead of just passing in hash keys). I'll look into this tomorrow.

[orenyk]

Here's a thought, what if we allow admins to configure a set of parameters and then run the above code to concatenate the results? I'm happy to use this just for affiliation (as opposed to using this for all of the different fields) since it's the only that could be non-standard. Let's see how it looks.

[orenyk]

Side note - this code should really be pulled out into its own class / module, but time is short so I'll leave that to a future issue.

[orenyk]

Ok, I think it's working, I'll just test on DEV and then issue a PR.