Datepicker next/previous month buttons invisible

[orenyk]

See below (screenshot from v3.4.10) - the circled button (and it's counterpart on the other side) are not visible in v5.5.1-rc1 although the buttons themselves are still there (i.e. if you click on the area it changes the month). We should do some front-end debugging and fix this.

[orenyk]

Ok, this is next for me, hopefully it will be fairly straightforward.

[orenyk]

Very weird. It's working locally for me, so I'll see if we can figure out what's going on on DEV.

[orenyk]

Looks like it's an assets thing, trying some stuff to see if it fixes things.

[orenyk]

Ok, nothing I've tried has been working. This definitely has to do with one or more of the following:

• We have some customized assets from the jquery-ui plugin in the vendor/assets/ directory from Properly deal with vendor assets #1142
• Rails 4 doesn't necessarily pre-compile assets from vendor/assets/ by default (although everything expect for the images appears to be working, e.g. CSS / JS, so it's probably working?)
• Rails is looking for the images in /assets/jquery-ui-bootstrap-images/ui-icons_222222_256x240.png, but the directory doesn't exist

Stuck for now so I'm leaving it for tonight, will get back to it later.

[orenyk]

Getting closer - looks like we have hard-coded asset names / urls in vendor/assets/stylesheets/jquery-ui-1.8.16.custom.css, so when we're pre-compiling assets it doesn't know where to find the actual image file. I'm going to see if I can figure out why we're using a custom version of jquery-ui as compared to the actual gem, because we might be able to avoid all of this by just not using a custom version. I'll take a look...

[orenyk]

Ok, so there are a total of two commits from 2012 that relate to this file - one when it was added (38cf7ee) and one where something was commented out having to do with forms (5e97347). Given that we're therefore using a version of jquery-ui that's almost 4 years old I'm going to try just removing the vendor files and seeing if things horribly break when we go back to the gem version. Worst case we can do a diff of our custom file and the original v1.8.16 file and make the appropriate changes.

[orenyk]

At the very least the datepicker no longer looks as Bootstrap-y; I'm putting together an override file with those styles and hopefully I can easily get this working.