Reservations table on User profile page not sortable

[orenyk]

Steps to replicate:

1. Visit User profile page (e.g. /users/ID)
2. Click on Reservation category (list of Reservations appears)
3. Click on header of one of the columns

Expected: table will be sorted by that column
Actual: nothing happens

This is a regression from v3.4

[orenyk]

Also, note that it's been requested that our default ordering for reservations in this view is sorted ascending by checkout date (vs. ID number / creation date). That should be pretty easy to switch in the controller / scope.

[alex-kogan]

@orenyk : I found this, I think we have a similar problem but I'm not sure how to implement it. Would appreciate you advice.

http://www.datatables.net/forums/discussion/3796/incorrect-table-width-in-hidden-containers

[orenyk]

This page should have a solution (I haven't read it in depth but it seems to be addressing the scenario we're dealing with). Let me know if you want me to review it / if you still have questions. Hope this helps!

[alex-kogan]

@orenyk - I made some changes and made it possible to make the table on full size except for the header...
There's still some debug code there, could you take a look at it?

[orenyk]

Sure, I'll review this later today and let you know how it looks.

[orenyk]

Ok, the fix on the link in my earlier comment should work, but the version of datatables that's included in the gem is outdated and doesn't include the required functionality (at least, $.fn.dataTables.tables() doesn't return an API instance, which is required). I'll look into just adding the latest files into vendor/ and adding them that way.

[orenyk]

Yup, that worked fine (at least locally). I've made a second branch (1378_unsortable_table_55) that includes the updates - take a look and see what you think.

[orenyk]

@alex-kogan do you mind if I move forward with this so that we can include in the next release candidate?

[orenyk]

I've implemented the requested sorting and generally improved the table partial in the second branch. @alex-kogan, unless you have any objections by tomorrow morning, I'm going to squash the commits on that branch, issue a PR for release-v5.5, and duplicate / cherry-pick for master. Thanks!