Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

Improve #md_link method implementation for objects #1382

Closed
@orenyk

Description

@orenyk

At the moment, links generated by the #md_link method for use in Reservation notes are using an incorrect hostname, vmBLAH.BLAH.yale.edu, instead of development.reservations.yale.edu. We've either left out a configuration parameter so that the URL helpers are pulling the wrong hostname or something else weird is going on. This should be fixed ASAP.

Update (2015-12-18)

This turned out to be a configuration error - I'm re-purposing this issue for re-factoring the md_link method slightly:

  • Take the link text as a parameter (defaulting to the current defaults) so that it can be used with arbitrary link text
  • Update the EquipmentItem#make_reservation_notes method to use Reservation#md_link method with the relevant verb as the link text parameter
  • Tests!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions