Archived reservations cannot be looked up after archiving

[orenyk]

If you archive a reservation it doesn't show up anywhere on the user profile page (e.g. under "Past" reservations) or on the reservations index page. This is critical since they might want to look it up again after archiving it. I think we should:

• Include archived reservations under the "Past" category on the user profile page
• Add an "Archived" category / filter on the reservations index page

[orenyk]

Last v5.5.1 issue that isn't assigned, let's see if we can get it done 😄

[orenyk]

Both subtasks are finished, although I didn't write specs for the user profile tweak. I'm also not 100% sure that lumping archived reservations under the "Past" category (vs. creating a separate one) is the best, although we currently have six categories in that view and adding a seventh wouldn't necessarily be great. My concern is that "Past" (as compared to "Past Overdue") implies that it was returned without issue, which is not strictly true.

The other option is just leaving the user profile page as-is and only displaying archived reservations on the index page, which I'm kinda okay with. @YaleSTC/reservations, any thoughts? I'll issue a PR regardless and we can discuss there.

[dgoerger]

I'm also not 100% sure that lumping archived reservations under the "Past" category (vs. creating a separate one) is the best, although we currently have six categories in that view and adding a seventh wouldn't necessarily be great. My concern is that "Past" (as compared to "Past Overdue") implies that it was returned without issue, which is not strictly true.

If an admin has specifically archived a reservation, I'd expect in the typical workflow that it's no-longer an issue, and I'm not certain from a functional point of view that Past vs Past Overdue necessarily implies Returned without issue vs Returned but there were issues. Functionally I think the terms imply Prior to today vs Prior to today and I owed $$, which would actually suggest that the proper scope for Past is something like APPROVED and STARTDATE-NONFUTURE and NOT-CHECKEDOUT.

Admins may care for more granular accounting on the Reservations admin listing (i.e. the monster datatables), but from an end user perspective, it's somewhat hilarious that I have a profile page and avatar for once borrowing a camera from the library. 😀 In this end user case however I expect Past to have its typical meaning of "prior to today". Possibly this is an argument for simplifying the user profile pages to have Archived, Current and Future, and Requested views only, with a fourth view visible to admins/checkout-persons with scope RETURNED and (HAS_NOTES or IS_OVERDUE), so admins can see at a glance if a patron is historically troublesome. This breakdown would be functionally similar to email filters All Mail / Archive, Inbox, Drafts, and Starred, respectively.

The other option is just leaving the user profile page as-is and only displaying archived reservations on the index page, which I'm kinda okay with.

What's the use-case for archived reservations? It's not clear to me why it wouldn't be visible on the patron's profile/record.