Add user search to checkout/checkin confirmation page [v5.5]

[orenyk]

From BMEC:

I’m entering all the reservation transactions we had today, and I discovered that the “Find User” box isn’t available on the “Check-Out/In Receipt for ___” page. Once I’ve checked out/in a patron, I was usually able to immediately search for another user. Now I have to navigate back to the Catalog in order to use the Find User function. This is a minor inconvenience, but it would be nice for that function to be restored.

This was removed in #776, it should be a pretty straightforward tweak.

[orenyk]

On second thought, this is a bit tricky since those views no longer have a sidebar to include this box on... @AlanLiu96, can you take this and brainstorm a clean way to add this box to all views (for checkout persons and above) without the cart? Thanks!

[AlanLiu96]

Sure, I'll take a look at it tonight!

[AlanLiu96]

Ok, just for the records, this is what the current page looks like now.

One way to solve this issue would be to reintroduce the box separately as a different partial using the code from the sidebar.
Pros: reusing code, satisfies client's requests
Cons: It adds a bit of clutter both visually and code wise as the page is setup without a sidebar right now

Another way, which I personally like better, but I'm not 100% sure how to implement is to reuse the catalog search box. If there are no results for equipment models, perhaps we could also search for users and redirect the search to the users's page using that search box.
Pros: Extending functionality of existing code, potentially useful for other cases?, no need for extra UI elements
Cons: a bit more complicated logic in the search, potentially (trivially?) increasing time to process searches

[orenyk]

Hmm I hear what you're saying about option 2; one thing to note is that the search box is in the navbar partial which is shared across all the views, so we'd have to add more logic to choose which search box to add. Also, it might confuse users who (rightly) would expect that UI element to perform a single task, regardless of the view.

This view is completely empty on the right side (since it was originally designed to include the entire sidebar), so why don't we just re-add the top part of the sidebar for the moment and we can (eventually) try to overhaul the UI in #1042? What do you think?

[AlanLiu96]

Oh I meant that the UI element would stay the same, the search logic would just include both users as well as items so like a universal search across all views similar to how github does its searching. I do agree though that this would require a larger overhaul over the UI, so for now, its probably better just to put the user search back where it was previously

[orenyk]

Oh that makes much more sense to me, sorry for misunderstanding. That's definitely a larger-scope item, but I'll add an issue for it if we don't have one already.

[AlanLiu96]

so I played with the divs a bit and I just put the search box back in. I figured that since the only people that would access that page are the ones that can checkout/checkin, it would be fine to just include the box back in at the side

fixing up the checkin part as well and then submitting pull req