AdminMailer broken [v5.5]

[orenyk]

2016-01-15

This has been identified as an issue with the way AdminMailer sets the from address in e-mails on deployments with a relative root. See below.

Original

Reported by BMEC, notes are being entered during checkin but the reservation is not being included in the hourly notes e-mail. Pretty critical!

[orenyk]

This was likely also due to e-mails being disabled this morning (via the DISABLE_EMAILS environment variable). I've created and checked out a dummy reservation on BMEC and hopefully they will see it in an upcoming notes e-mail; if they do we can just close this issue. I'll update tomorrow once I hear back from them.

[orenyk]

Similar to #1428, this isn't turning out to be so straightforward. The notes_unsent flag was set when I checked out a Reservation with notes, and then later unset, implying that the rake task ran. I'm just trying to confirm whether or not the e-mail went out without reservations or if no note e-mail was sent at all. I do know that some e-mails have been going out so the mailer is performing deliveries in general; this is getting pretty frustrating.

[orenyk]

Thanks to @dgoerger we've figured this out - when we updated the no-reply address for AdminMailer e-mails in #1240 we broke things since it's including the relative root (so no-reply@reservations.yale.edu/STUFF) which leads to an invalid from address and the mail server refusing to deliver the e-mail. We'll have to update that code - I'm going to get this done over the weekend, include a CHANGELOG update, and release that as v5.5.2 for immediate deployment so that admin e-mails start sending again. All the other issues will be worked on over the rest of the month for release in v5.5.3.