User Import doesn't handle CR line endings [v5.5]

[dgoerger]

I was helping Laurel/BMEC use the user import function, and noticed it was choking on her CSV, which was created by Microsoft Excel 2011 and riddled with ^M characters, which is the CR of Mac-only line ending CR. The server-side log error messages indicated it couldn't find any users to import. (specifically choking on line 60 of import_users_controller.rb, method keys unavailable on object nil---indicating there was no first user in the hash of imported users. Using Vim, I replaced all ^M characters with standard \r, and the import progressed further.

EDIT: The issue was originally erroneously reported as CRLF incompatibility; it's CR and I've edited the above for clarity.

[esoterik]

@dgoerger could you get me a csv that caused this problem so I can make sure I've solved it properly?

[orenyk]

@dgoerger 🔔

[dgoerger]

Sorry, it appears to have been CR line endings, which is even more absurd and less widely used. I'll update the description.

Hopefully git clone won't rewrite this file to the more common LF line terminator (it worked for me, but if your gitconfig is configured to convert e.g. for Windows compatibility that may present an issue): https://gist.github.com/dgoerger/354c79fe9b16f3cb493d