Change missed expiration default to 1 week [v5.5]

[orenyk]

2016-02-10

In #594 we added an expiration period to missed reservations but also changed the default behavior of Reservations from deleting missed reservations immediately to keeping missed reservations forever. We should change the default to 1 week in our app_setup task.

Original

Saw this while looking into #1489, reservations are correctly being flagged as missed but not being deleted correctly. It's possible this has to do with the deletion task looking at the due date, not the start date, but I'm not sure.

[orenyk]

Verified on PROD SDMP

[orenyk]

Never mind I'm an idiot - they're both set to keep missed reservations forever 😞. I'm just going to check and see if we switched what a blank setting means (i.e. if in v3.4 it meant don't keep and in v5.5 it means keep forever) - if so I'll e-mail our clients to ask them to set it appropriately.

[orenyk]

This setting was actually added post-v3.4 in #594, so everyone now defaults to the opposite of what things used to be. I'm re-opening this to change the default behavior to deleting after a week and will e-mail our clients to update their instances.