Self-created users cannot accept ToS [v5.5]

[orenyk]

From BMEC:

When first-time users register under their own netIDs, they used to have to check the box for “Accepting the Terms of Service”. Now, they can just register without accepting the ToS, and it slows down the checkout process when the Checkout Person has to certify that the patron does accept. It’s no problem when we have the time to add new users ourselves, but it’s easier for patrons to read through the ToS on their own time (or just blindly accept them) before picking up their reservations.

This was changed in #774 / 818959c, let's get it fixed in v5.5.6.

To Do

• Fix logic for when the accept ToS checkbox is disabled
• If we don't show the checkbox on the new user form, we shouldn't show it if we submit an incorrect form

[AlanLiu96]

Not sure if this would be better here or in another issue, but the disabled ToS box(#1320) appears again if you can't manage reservations if you try to submit an incomplete user registration form or an incorrectly filled out one. It probably will be addressed through this issue though.

[orenyk]

Good catch - when UsersController#create fails some of our display logic apparently no longer applies. We'll consolidate that bug into this issue, thanks!

EDIT Screenshots: