This repository was archived by the owner on Jul 24, 2020. It is now read-only.
This repository was archived by the owner on Jul 24, 2020. It is now read-only.
Clean up #1337 #1499
Closed
Description
While dealing with merge conflicts for #1360 I caught some messy code from #1337:
- We only
include CsvExport
in theCategoriesController
, meaning that theindex
action with azip
format is probably broken for theEquipmentModelsController
and theEquipmentItemsController
. - Luckily, the links on all of the views for equipment export point to
/categories.zip
, so we're never hitting the routes for the other controllers.
We should be more consistent, either including it in all the controllers or just the one but then updating the index
action in the others. @esoterik I'm giving this to you since the original issue was yours; sorry for not catching this earlier! We can wait for this until #1360 is finalized to avoid merge conflicts in the controllers.
Activity