Equipment Items Show - should have history

[caseywatts]

October 2014

Things to do (copied from below):

• Add notes column to equipment_objects table (increase default length, prevent null)
• Modify migration to record existing history
• Add display of notes to equipment item show view
• Add code to checkout method to prepend to equipment item notes
• Add code to checkin method to prepend to equipment item notes (with reservation notes?)
• Add code to deactivate to prepend to equipment item notes
• Add code to activate to prepend to equipment item notes
• Add code to edit to prepend to equipment item notes if switched from one reservation to another
• Add code to edit to prepend to equipment item notes if switched with an available item (see reservations_controller.rb)
• Add code to create to prepend to equipment item notes
• Ensure that deactivation reason is not null or empty string FIXED IN Add warning when deactivating equipment if it will violate availability #983
• Deal with equipment import as well
• Write tests

---

For missing laptops, it really helps to know who previously had the laptop.
For broken laptops, it really helps to know when damage was noted.

The Equipment Items Show page should give an account of both (maybe two columns or tabbed?):

1. Previous Reservations
2. Previous Notes

[mnquintana]

YES – finally a good reason to have an Equipment Items show page!

[squidgetx]

Closed via #319

[orenyk]

Looking back over this (I came via IdeaScale), I think there might still be value in adding some kind of history to the equipment item show page, since as far as I can tell (with limited testing) we don't log the checkin/checkout of specific equipment items, so tracking that history would be difficult. Thoughts?

[mnquintana]

@squidgetx Why did you close this? This wasn't actually implemented in #319 - #319 really just laid the groundwork for this feature to be implemented.

[squidgetx]

My bad, I misunderstood the issue

[orenyk]

Especially now that we have deactivation, having a table with date, type of transaction (reservation or deactivation/reactivation), and user who made the change or borrowed the equipment (maybe also checkout/checkin person) would be highly beneficial.

[orenyk]

Started working through this, trying to work out the ActiveRecord calls we'll need since paper_trail doesn't know enough to associate changes to reservations with the associated equipment item (this makes sense since we don't actually touch the equipment item record, just worth noting). So far I have

eo = EquipmentObject.includes(reservation: :reserver).find(ID)

which correctly hits the Reservation table and the User table, but I haven't yet figured out how to pull information about the reserver without hitting the User table again. I'll keep working on it, but since I discovered some nice bugs (#722 and #723) while messing with this, I think those are higher priority.