Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

Renewals?? #674

Closed
Closed
@squidgetx

Description

@squidgetx

Currently, patrons can make renewals that could subtly break some of the other validations

  • no check is made for the new due date on a blackout date
  • no check is made for max models/categories
  • etc.
    After Fundamental Rewrite of Validation System #644 is merged I think the easiest thing to do would be to rewrite max_renewal_length to take all of these things into account. It can simply spit out a modified date such that the extension wouldn't break any 'soft' validations, instead of only checking available like it does now.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions