require_phone can make users invalid

[orenyk]

If an admin checks off the require_phone setting after some users have been created without phone numbers, those users will fail validation. I'm not sure what the best way to deal with this is; we don't want dummy data to be added whenever we change the setting since it is there to ensure that the admin has a valid phone number for each user. Maybe we notify the admin in the settings screen of any missing phone numbers when they try to change the setting?

[squidgetx]

If the admin does this the application shouldn't break, it will just require a valid phone number to be present whenever that user is edited again.

It would be cool if the app showed a list of all the missing phone numbers but honestly I feel like that falls squarely into the 'nice to have but there are other things to work on' pile

[orenyk]

Or the records will fail validation if we try to import the data from one instance to another (i.e. if we try to import current data into our development instance for testing). We can hack around it with a simple SQL update (as we already did) but this could come up again and I don't think fixing it would be too complicated.

[squidgetx]

I'm still not convinced. Couldn't we just set the appconfig to not require phone => true in the case when we're importing data? There's no way to actually make the admin update all the missing phone numbers, all we can do is give a warning. Warnings are nice to have but will only cut down on the number of invalid records rather than erasing them completely.

[orenyk]

Yea I guess we could go into the appconfig to change that setting during import, but it's still not ideal. That said, I think adding a warning to the app settings screen if there are "invalid" users when that option is checked off is worthwhile; definitely not urgent but that and a list of those users shouldn't be too hard to add in the future. Bumping this to 4.1 for now.