Should equipment models have their own max checkout length?

[squidgetx]

Seems unwieldy to have to constantly reference categories all the time from both the dev and admin perspective. What if an admin has several different types of cameras, some that can be checked out for longer than others?

[orenyk]

I think so. For some reason in my head they did, but I think I was thinking of renewals vs checkouts. How about having limits defined in the categories that can be overridden in the equipment model? Depending on how the inventory hierarchy is set up, retaining the ability to define limits in the category makes sense to me.

[dgoerger]

Wait I totally thought we (once) had a check to the effect of

unless equipment_model.max_length
  max_length = category.max_length
else
  max_length = equipment_model.max_length
end

We should definitely have something like this, seeing as we thought we did but we don't. :P

[orenyk]

Do we have that check? I might have missed it...

[dgoerger]

apparently not, per EquipmentModel attributes:

attr_accessible :name, :category, :category_id, :description, :late_fee, :replacement_fee,
      :max_per_user, :document_attributes, :deleted_at,
      :checkout_procedures_attributes, :checkin_procedures_attributes, :photo,
      :documentation, :max_renewal_times, :max_renewal_length, :renewal_days_before_due,
      :associated_equipment_model_ids, :requirement_ids, :requirements

I'm responsible for most of the renewal code, so I must've been thinking of those checks. No idea why we wouldn't also have it for max_checkout_length.