Fix "Empty Cart"

[orenyk]

First, the cart emptying should trigger the spinner since it takes a non-trivial amount of time to complete (at least as of v3.4.2 on BMEC). Also, I suggest that we either change the button behavior or implement a "reset cart" feature to also reset the dates and reserver.

[orenyk]

The latter was requested by the BMEC admins (e-mail below), let's get this in 3.4.3.

In our previous version of Reservations, when a checkout person or admin created a reservation for a patron (or if you hit the 'empty cart' button), the 'Reserving For' would revert back to the checkout person's name. Now, it sticks with the last patron a reservation was created for. Is there a way we could make the cart go back to doing what it did before with patron names? If one of us accidentally makes a reservation under the wrong name, I would much rather it be under the checkout person than some patron who never took out that equipment. It will save us some unpleasant arguments.

[orenyk]

Damn, this isn't fully fixed. We also have to fully reset the cart after a reservation is created (right now it's still just resetting the items hash). After that's done we can close this issue.

[squidgetx]

I went (in admin mode) to make a reservation and the cart reset after I completed the reservation process (on release-v3.4). Am I missing something?

[orenyk]

Did you confirm that the reserver and start/due dates also changed? I was creating reservations last night for other users and the reserving for field didn't reset after the reservations were completed.