Checkout persons can't use autocomplete

[dgoerger]

The dropdown fields for "Search for" and "Reserving for" won't complete the search when the user is a checkout person. It works correctly for admins.

[dgoerger]

important:

following debugging steps on this page, I found for a checkout person:

ability.can?(:get_autocomplete_items, User)

to return true only if I specify can :get_autocomplete_items, User in ability.rb. However, adding this does not make autocomplete work.

_EDIT:_ Adding can :manage, User allows checkout persons to utilize the autocomplete feature, but we don't really want to give them :manage ability.

[dgoerger]

found it, we need to give checkout persons the ability to access :autocomplete_user_last_name, which is the weird name of the route we've given to autocomplete. I'll upload a patchset momentarily.

[dgoerger]

@orenyk, review/merge these? please and thank you! :)

[orenyk]

Not currently on a computer, I'll get on it when I am. Should we push these live asap? Thanks for handling it!

[dgoerger]

Let's try to push v3.4.3 after this and #848 gets fixed/merged.

Hopefully we won't see any more critical bugs on v3.4.2, but it might be wise to let the dust settle for a few days, in case anything else crops up. :)