[v3.4] Reservation notes e-mails not being sent

[orenyk]

From BMEC:

I don't think Reservations is sending reservation notes anymore. These are the notes that are generated whenever a check in/out step is left unchecked or whenever something is entered in the "notes" field during checkin/out

and

The admins aren't receiving emails when a note on check-in/out is entered. The notes on the reservation page themselves are posting right, but we aren't getting emails for them.

This is critical, let's get it in v3.4.3

[orenyk]

Somehow we stopped modifying the :notes_unsent boolean to trigger the rake task to send the relevant emails. We should probably refactor this behavior since we probably don't want to trigger an e-mail every time the notes are sent, but this should be fixed ASAP and we can revisit it in v4.0 (maybe #836).

[orenyk]

PR #908 issued for v3.4, we should implement those changes as applicable in #836 before merging.

[orenyk]

Update from BMEC:

So now we are getting the "[Reservation] Reminder: equipment check in" notices in addition to the "[Reservation] OVERDUE" notices we were already getting. We don't really need a copy of the check in reminders for patrons; just the overdue notices and the "[Reservation] Notes for MM/DD/YY" notices.

I'll add this to the branch (see #908 for discussion).