Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

[1056] Contributing.md #1180

Merged
merged 1 commit into from
Mar 30, 2015
Merged

[1056] Contributing.md #1180

merged 1 commit into from
Mar 30, 2015

Conversation

orenyk
Copy link
Contributor

@orenyk orenyk commented Mar 2, 2015

Resolves #1056, please check for typos but also make sure the content is good and makes sense. Thanks!

@mnquintana mnquintana self-assigned this Mar 2, 2015
@@ -0,0 +1,170 @@
# Contributing to Reservations
Thanks so much for helping with the development of Reservations! This guide will cover the process for helping out with the project and should allow you to get started quickly and easily. If you need any help with contributing, please e-mail `stc-reservations{at}yale{dot}edu` to contact the core team.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want we could also mention that they can @-mention the core team with @YaleSTC/reservations

@mnquintana
Copy link
Contributor

Would you mind making this fit 80 chars per line?

@orenyk
Copy link
Contributor Author

orenyk commented Mar 6, 2015

Is it standard to have markdown files be 80 characters long? I guess the Atom guide basically does it (with exceptions for links), no reason not to.

@orenyk
Copy link
Contributor Author

orenyk commented Mar 6, 2015

Ok, 80 characters or less it is (more or less, some exceptions made for links and some other formatting). Let me know if I screwed anything up while splitting up lines or if there are any other changes to make, thanks!

fork as the head fork with your branch as the compare brach. Click "Create
Pull Request" and add a description which references the original issue (e.g.
`Resolves #1234`), describes the changes you made and any new tools or
libraries you added, as well as any breaking changes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think anywhere we have a list of steps (like this section) we should have bullet points

@orenyk
Copy link
Contributor Author

orenyk commented Mar 10, 2015

Ok, fixed the last couple of comments. How does it look?

@squidgetx squidgetx changed the title #1056 Contributing.md [1056] Contributing.md Mar 23, 2015
@orenyk orenyk force-pushed the 1056_contributing_md branch from dea58e4 to d117a4a Compare March 30, 2015 02:27
orenyk added a commit that referenced this pull request Mar 30, 2015
@orenyk orenyk merged commit 6a000b9 into master Mar 30, 2015
@orenyk orenyk deleted the 1056_contributing_md branch April 22, 2015 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CONTRIBUTING.md guide for future contributors
2 participants