This repository was archived by the owner on Jul 24, 2020. It is now read-only.
[1082] remove the equipment item index page #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
link in navbar? |
|
|
Note that in removing the equipment items links I changed the 'equipment' link for checkout persons to link to the equipment models index and also adjusted the view permissions such that it gives them a little bit more useful information |
| @@ -4,5 +4,4 @@ | |||
|
|
|||
| <p> | |||
| <%= link_to "Show", @equipment_item %> | | |||
| <%= link_to "View All", equipment_items_path %> | |||
There was a problem hiding this comment.
should we replace this with a link to /equipment_model/:id/equipment_items?
|
Looks good, the only change I'd make is replacing the "View all" link on the bottom of the resource views with a link to the nested equipment item index for the item's equipment model if we have it. Otherwise feel free to squash / merge. |
|
yes |
| @@ -5,7 +5,7 @@ | |||
| <%= f.input :serial %> | |||
| <div class="form-group"> | |||
| <div class="col-sm-offset-2 col-sm-10"> | |||
| <%= f.button :submit, cancel: equipment_items_path %> | |||
| <%= f.button :submit, cancel: @equipment_item %> | |||
There was a problem hiding this comment.
What happens if we're in the new method?
|
SQUASH IT. |
|
👢 |
remove links to equipment item path make equipment model page more informative for staff re-add links; re-add index for sub pages restore spec remove cancel
squidgetx
force-pushed
the
1082_remove_ei_index_2
branch
from
24275d5 to
1cf3e9f
Compare
squidgetx
added a commit
that referenced
this pull request
Mar 30, 2015
[1082] remove the equipment item index page
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1082