This repository was archived by the owner on Jul 24, 2020. It is now read-only.
[1251] autocomplete ux #1252
Merged
[1251] autocomplete ux #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ul.ui-autocomplete li a.ui-state-hover, ul.ui-autocomplete li a.ui-state-active { | ||
| background-color: #FFFCB2; | ||
| ul.ui-autocomplete li.ui-state-focus { | ||
| background-color: #337ab7; |
There was a problem hiding this comment.
Can we use SASS (e.g. a variable) for this instead of hard-coding a number that we'll have to remember to come back and change if we ever change our UI / color scheme?
There was a problem hiding this comment.
👍 You should use the variable Bootstrap defines for this value instead of hard-coding it: http://getbootstrap.com/customize/#dropdowns
|
Awesome, looks great. Squash / merge / update CHANGELOG away! 😄 |
| ul.ui-autocomplete li a.ui-state-hover, ul.ui-autocomplete li a.ui-state-active { | ||
| background-color: #FFFCB2; | ||
| ul.ui-autocomplete li.ui-state-focus { | ||
| // background-color: #337ab7; |
There was a problem hiding this comment.
Indentation in this whole block is a bit wonky
There was a problem hiding this comment.
Also good catch. We can also get rid of the commented style.
squidgetx
force-pushed
the
1251_autocomplete_highlight
branch
from
2ccfc2b to
fe30f85
Compare
Closes #1251 * Use bootstrap blue to highlight the current selection * Use pointer cursor to indicate the selection can be clicked
squidgetx
force-pushed
the
1251_autocomplete_highlight
branch
from
fe30f85 to
e4367a3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1251 by using bootstrap blue for highlighting as well as changing the pointer cursor for additional visual cue. Also removes some old css that wasn't doing anything
