This repository was archived by the owner on Jul 24, 2020. It is now read-only.
[1265] Setup script for setting up initial user doesn't echo the typed password #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coollog
changed the title
|
this looks good! |
|
Looks good to me too - @coollog can you update the commit message to fit the guidelines in our Contributing guide? |
coollog
force-pushed
the
1265_hide_password_on_cmdline
branch
2 times, most recently
from
a6dc55c to
f098c2f
Compare
|
Okay, the commit message has been fixed! |
|
Sorry to nitpick, but the first line of the message is a bit too long; can you keep it under 72 characters? Thanks! |
coollog
force-pushed
the
1265_hide_password_on_cmdline
branch
2 times, most recently
from
ef57595 to
d263763
Compare
coollog
force-pushed
the
1265_hide_password_on_cmdline
branch
from
d263763 to
7f56e35
Compare
|
Nit has been picked! |
|
great, merging! |
orenyk
added a commit
that referenced
this pull request
Oct 20, 2015
Setup script for setting up initial user doesn't echo the typed password
|
Done! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1265
This also makes the same script in db/seeds.rb (prompt_password) not show the typed password too.