This repository was archived by the owner on Jul 24, 2020. It is now read-only.
[1384] Add optional archival deactivation of equipment #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyk
force-pushed
the
1384_autodeactive_equipment
branch
2 times, most recently
from
56fbf99 to
dd84088
Compare
|
This might be out of scope, but it would be nice to add a checkbox to the archive prompt to deactivate the item as well as having the global option |
|
Otherwise, looks good! |
|
Good point, I'd just have to rebuild that prompt with something like a jQuery UI dialog if we wanted anything more complex. I'm going to leave that to another issue (we can pull the default state of that checkbox from the global config). |
|
Rebasing since it's out of date and merging following a green build. |
Resolves #1384 - add autodeactivate_on_archive parameter to AppConfig - move equipment item deactivation to a model method - tweak ReservationsController#archive method to implement auto-deactivation - add feature specs for reservation archiving - add model specs for EquipmentItem#deactivate - add controller specs for ReservationsController#archive with auto-deactivation - FeatureHelpers#app_setup now deletes any pre-existing AppConfigs
orenyk
force-pushed
the
1384_autodeactive_equipment
branch
from
dd84088 to
12f517c
Compare
|
Weird intermittent failure, opened up a new issue (#1537). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1384
autodeactivate_on_archiveparameter toAppConfigReservationsController#archivemethod to implement auto-deactivationEquipmentItem#deactivateReservationsController#archivewith auto-deactivationFeatureHelpers#app_setupnow deletes any pre-existingAppConfigs