This repository was archived by the owner on Jul 24, 2020. It is now read-only.
[1411] Running tests with USE_LDAP enabled outside of Yale breaks things #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esoterik
force-pushed
the
1411_fix_ldap_tests
branch
from
3fad48b to
839b6ef
Compare
AlanLiu96
approved these changes
Oct 28, 2016
|
Just noting that the commit message needs to be fixed 😄 |
esoterik
force-pushed
the
1411_fix_ldap_tests
branch
from
839b6ef to
8704318
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1411
The
UsersControllertest failure is fixed in #1595 by stubbingUser.search_ldap.Importing users with LDAP is currently untested, so defaulting
USE_LDAPtonilallows those tests to run even if the variable is set in.env. Setting this default would be a lot nicer if #1422 was merged, because we could have a.env.testfile withUSE_LDAP=0rather than deletingUSE_LDAPfrom theENVhash before running the test suite (my current solution).I don't think there are any other tests that hit LDAP; the model method isn't tested.