Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

[1606] Write Tests for Ability #1626

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[1606] Write Tests for Ability #1626

wants to merge 3 commits into from

Conversation

esoterik
Copy link
Collaborator

Resolves #1606

esoterik
esoterik reviewed Aug 11, 2016
View reviewed changes
spec/models/ability_spec.rb
it { is_expected.not_to be_able_to(:view_as, :superuser) }
it { is_expected.not_to be_able_to(:appoint, :superuser) }
it { is_expected.not_to be_able_to(:destroy, User, role: 'superuser') }
it { is_expected.not_to be_able_to(:update, User, role: 'superuser') }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two fail; I haven't been able to determine why

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll dig into cancancan and try to figure this out

@esoterik
Copy link
Collaborator Author

Note that this PR should also remove all of the controller tests that it obsoletes

@esoterik esoterik added pri: 5 and removed pri: 3 labels Sep 12, 2016
@orenyk
Copy link
Contributor

orenyk commented Sep 18, 2016

I'll review the spec to make sure all abilities were covered, and following the resolution of these two tests failing you should deal with all the controller updates and I'll review again once those are done.

@orenyk orenyk self-assigned this Sep 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@orenyk orenyk

Labels
1 - working diff: 3 pri: 5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esoterik @orenyk