This repository was archived by the owner on Jul 24, 2020. It is now read-only.
Repair equipment_model generator to handle ordering #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeffman
force-pushed
the
1662_fix_ordering_generator
branch
2 times, most recently
from
b29e729 to
d6a598a
Compare
esoterik
reviewed
Feb 8, 2017
spec/lib/generator_spec.rb
Outdated
| @@ -8,25 +8,30 @@ | |||
| expect(Generator.send(method)).to be_truthy | |||
| end | |||
| end | |||
| shared_examples 'generates multiple valid' do |method| | |||
| it method.to_s do | |||
| expect(5.times { Generator.send(method) }).to be_truthy | |||
There was a problem hiding this comment.
this test should probably also take the model name so we can actually test that the correct number are saved to the database -- expect(klass.count).to eq(5)
spec/lib/generator_spec.rb
Outdated
| @@ -37,7 +42,7 @@ | |||
| Generator.equipment_model | |||
| Generator.equipment_item | |||
| end | |||
| it_behaves_like 'generates a valid', :reservation | |||
| it_behaves_like 'generates multiple valid', :reservation | |||
There was a problem hiding this comment.
we shouldn't do this because sometimes random reservation generation will fail -- we catch the exception because its less complicated than ensuring valid data
zeffman
force-pushed
the
1662_fix_ordering_generator
branch
from
8707c08 to
e487979
Compare
Resolves #1662 - set ordering to number of existing models in equipment_model generation - add validations for generating multiple objects - resolves error that can occur when randomly generating reservations for equipment_model with max_checkout_length = 1
zeffman
force-pushed
the
1662_fix_ordering_generator
branch
from
e487979 to
57f4215
Compare
esoterik
approved these changes
Feb 11, 2017
|
merging! |
|
@zeffman can you add this to the changelog? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1662
equipment_model with max_checkout_length = 1