This repository was archived by the owner on Jul 24, 2020. It is now read-only.
Refactor Reservation Model #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
squidgetx
commented
Jul 3, 2014
squidgetx
commented
- is_eligible_for_renew
- max-renew_length
- replace unnecessary functions with scopes
|
sweet |
| max_renewal_times = Float::INFINITY if max_renewal_times == 'unrestricted' | ||
|
|
||
| max_renewal_days = self.equipment_model.maximum_renewal_days_before_due | ||
| max_renewal_days = Float::INFINITY if maximum_renewal_days_before_due == 'unrestricted' |
There was a problem hiding this comment.
should the conditional be testing max_renewal_days instead of maximum_renewal_days_before_due?
|
Code looks good visually, can't currently check out the branch to run tests and make sure nothing seems broken. Nice work! |
|
Looks good! Let's set this for 3.4.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.