Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

If an equipment item is overdue, then it should not be available to check out #625

Merged
merged 5 commits into from
Jul 8, 2014

Conversation

squidgetx
Copy link
Contributor

Currently, if an equipment item is overdue, then this is its availability:

  • Unavailable for the length of the reservation
  • Unavailable on current day
  • Available tomorrow and beyond

This doesn't make sense. We shouldn't allow users to reserve equipment that the loan office doesn't have, since this relies on hoping that users with overdue equipment will return them as soon as possible. We should make it so that if an equipment item is overdue, then it is unavailable for check out until checked back in.

@mnquintana mnquintana added this to the 3.4.0 milestone Jul 3, 2014
@squidgetx
Copy link
Contributor

This is implemented in the backend of the current instance of development. However, it isn't in the calendar,so I'll need to make sure to implement that.

@mnquintana
Copy link
Contributor Author

Did you convert this into a PR from an issue? @squidgetx

@squidgetx
Copy link
Contributor

yes

@mnquintana
Copy link
Contributor Author

We shouldn't do that anymore - GitHub thinks I'm submitting this PR because I created the issue, even though you're the one actually submitting it.

@orenyk
Copy link
Contributor

orenyk commented Jul 8, 2014

That's not what it says on the website... it's saying that @squidgetx wants to merge the commits.

@mnquintana
Copy link
Contributor Author

Hmm true - it was just in the Slack feed.

@dgoerger
Copy link
Contributor

dgoerger commented Jul 8, 2014

this seems to work as expected!

dgoerger added a commit that referenced this pull request Jul 8, 2014
If an equipment item is overdue, then it should not be available to check out
@dgoerger dgoerger merged commit f80f027 into development Jul 8, 2014
@squidgetx squidgetx deleted the 625_calendar_overdue branch July 11, 2014 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants