Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

620 autocomplete #670

Merged
merged 7 commits into from
Jul 14, 2014
Merged

620 autocomplete #670

merged 7 commits into from
Jul 14, 2014

Conversation

squidgetx
Copy link
Contributor

No description provided.

@squidgetx
Copy link
Contributor Author

Waiting on #644 , before I can have the cart interpret a nil reserver id as the current user

@orenyk
Copy link
Contributor

orenyk commented Jul 11, 2014

Played with this locally, I'm not 100% sure how this addresses the issues in #620 (unless I missed something): typing a space breaks autocomplete and we're still using the same gem. I do think that moving the code over the users controller makes way more sense, though. Am I missing something @squidgetx?

@squidgetx
Copy link
Contributor Author

Yeah, I couldn't get the space to work and there aren't any other good gems out there as far as I can tell. I've just tried to move the code over and also enabled autosubmit on user search and auto-changing of the reserver field to the current user if it's changed to blank

@orenyk
Copy link
Contributor

orenyk commented Jul 11, 2014

Gotcha, that makes sense. If you have any other details on why the space thing is breaking autocomplete we should add it to the original issue (#620) for reference, and while I think we can pull this now, we should really try to fix that because that's a huge usability failure.

squidgetx added a commit that referenced this pull request Jul 14, 2014
@squidgetx squidgetx merged commit 6dadb4d into development Jul 14, 2014
@squidgetx squidgetx deleted the 620_autocomplete branch July 22, 2014 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants