This repository was archived by the owner on Jul 24, 2020. It is now read-only.
Cart compatibility upgrade #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me |
| # than a Hash (see #587), regenerate the Cart. | ||
| # TODO: Remove in ~2015, when nobody could conceivably run the old app? | ||
| def make_cart_compatible | ||
| if session[:cart].items.is_a? Array |
There was a problem hiding this comment.
Should we change this to test for anything that isn't a hash, rather than specifically arrays? Not sure it's necessary but once we're already testing, we can eliminate anything invalid.
…aleSTC/reservations into 667_cart_compatibility_upgrade
shippy
added a commit
that referenced
this pull request
Jul 10, 2014
Implements cart compatibility upgrade, as per #667.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To update possible old Cart structures stored in session. (This branch fails a test in the EquipmentModel spec, that it failed prior to branching off development.)