Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update run-clangcldocker.sh #608

Merged
merged 1 commit into from
Mar 12, 2024
Merged

refactor: update run-clangcldocker.sh #608

merged 1 commit into from
Mar 12, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Mar 10, 2024

Small changes, nothing noteworthy

@anonrig anonrig requested a review from lemire March 10, 2024 19:53
@anonrig
Copy link
Member Author

anonrig commented Mar 11, 2024

@lemire Can you take a look at this?

lemire
lemire approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything objectionable. I trust that you have tested it.

@anonrig anonrig merged commit 4a97a78 into main Mar 12, 2024
35 checks passed
@anonrig anonrig deleted the update-docker-clangcl branch March 12, 2024 01:30
@lemire lemire mentioned this pull request Mar 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anonrig @lemire