Skip to content

Commit

Permalink
Bump golangci-lint v1.55.2; fix testifylint issues (#48)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexandear authored Feb 5, 2024
1 parent 2342280 commit 2d78feb
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
branches: [main]

env:
GOLANGCI_LINT_VERSION: v1.54.2
GOLANGCI_LINT_VERSION: v1.55.2

jobs:
lint:
Expand Down
1 change: 0 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
run:
concurrency: 8
deadline: 10m
issues-exit-code: 1
tests: true

Expand Down
10 changes: 5 additions & 5 deletions main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package main
import (
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/alexandear/import-gitlab-commits/internal/testutil"
)
Expand All @@ -14,7 +14,7 @@ func TestExecute(t *testing.T) {

err := Execute(testutil.NewLog(t))

assert.ErrorContains(t, err, "GITLAB_TOKEN")
require.ErrorContains(t, err, "GITLAB_TOKEN")
})

t.Run("error when wrong GITLAB_BASE_URL", func(t *testing.T) {
Expand All @@ -23,7 +23,7 @@ func TestExecute(t *testing.T) {

err := Execute(testutil.NewLog(t))

assert.ErrorContains(t, err, "GITLAB_BASE_URL")
require.ErrorContains(t, err, "GITLAB_BASE_URL")
})

t.Run("error when wrong COMMITTER_NAME", func(t *testing.T) {
Expand All @@ -33,7 +33,7 @@ func TestExecute(t *testing.T) {

err := Execute(testutil.NewLog(t))

assert.ErrorContains(t, err, "COMMITTER_NAME")
require.ErrorContains(t, err, "COMMITTER_NAME")
})

t.Run("error when wrong COMMITTER_EMAIL", func(t *testing.T) {
Expand All @@ -44,6 +44,6 @@ func TestExecute(t *testing.T) {

err := Execute(testutil.NewLog(t))

assert.ErrorContains(t, err, "COMMITTER_EMAIL")
require.ErrorContains(t, err, "COMMITTER_EMAIL")
})
}

0 comments on commit 2d78feb

Please sign in to comment.