makeqctoolsreport - fix transcode function and add shebang #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially ffmpegstring was a string, but subprocess.call requires a list of arguments. Here was the error that I kept getting:
This pull request turns the command into a list. Because
inputCodec
andfilterString
can be empty, it causes the ffmpeg command to fail, which is why theif
statement is there.Why is the transcode necessary at all? Can't you just run ffprobe on the source file directly?
Also I added a shebang for good measure.