Build helm values schemas with kubernetes 1.29 resources #38460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiaHT
requested review from
potiuk,
ashb,
dstandish,
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:dev-tools
area:helm-chart
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
potiuk
approved these changes
Mar 26, 2024
|
In the meantime we had some conflicts so if you could rebase and fix them @mathiaHT - that woudl give chance for the others to take a look and merge it. |
hussein-awala
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Most of the updated resources were deprecated in 1.26+.
In general, I wonder if we should use the max-supported version or the min-supported version to generate the schema. For this PR, it looks like all updated versions are already present in 1.26, but not sure if it will be always the case.
LGTM
mathiaHT
requested review from
bolkedebruin,
kaxil,
pierrejeambrun,
eladkal,
o-nikolas,
uranusjr,
ryanahamilton,
bbovenzi,
ephraimbuddy and
XD-DENG
as code owners
… added display name for dag / task (v2) (apache#38446) * Add display name in DAGs and tasks Co-authored-by: Tzu-ping Chung <[email protected]> Co-authored-by: Aleksandr Shelukheev <[email protected]> * Fix frontend issues * Fix pytests * Add DAG display tool tips * Implement national language char display example oon two DAGs * Review nit from other PR * Fix WWW pytest on HTML code * Review feedback, make task_display_name a property, not a field in mapped operator * Review feedback, rename internal fields * Small nit, optimize sorting on DAG home page with display name * Review feedback * Fix pytests in API plus review feedback on API * Review feedback, extend schema, update apispecs and fix breadcrumb navigation * nit, update page titles as well * Fix pytests for extended API model * Ensure mapped operator also provides a display string * Ensure display field is only serialized if different from task id * fix pytest for API * Review feedback from TP * Move labels down to base and mapped operator * Move labels up to abstract operator * Only one decorator is needed --------- Co-authored-by: Vincent Gao <[email protected]> Co-authored-by: Tzu-ping Chung <[email protected]> Co-authored-by: Aleksandr Shelukheev <[email protected]>
…8474) This field will be used by AIP-61 code to store and retrieve which executor a task is meant to run on. --------- Co-authored-by: Niko Oliveira <[email protected]>
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
utkarsharma2
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #38453
Build helm chart/values.schemas.json definitions using kubernetes 1.29.
The initial objective was to use the kubernetes sidecar feature: https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/