-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize quotes when parsing urls in logs #40508
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
The regexp is a bit magic, but it does the job :) |
Need static checks fix though (recommend installing pre-commit) |
Thanks @potiuk . I found the failing test was successful :
And pushed a commit. Could you guide me how to re-trigger static-check? |
As this is your first contribution, maintainer has to approve and run your workflow (I just did) |
Still some checks are failing. Installing pre-commit and running |
I tried to run
But since the change is not related to my change, I'm not sure how I can fix this issue.. |
Finally passed :) Yay~ |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
🎉 |
--------- Co-authored-by: Jacob Lee <[email protected]> (cherry picked from commit 2f9b23d)
--------- Co-authored-by: Jacob Lee <[email protected]>
Currently, the log UI doesn't recognize single or double quotes when a url is parsed as a hyperlink, so when you click on it, you're taken to the wrong url, which is quite an inconvenient experience. I've created a PR to fix this.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.