Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize quotes when parsing urls in logs #40508

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

smlee729
Copy link
Contributor


Currently, the log UI doesn't recognize single or double quotes when a url is parsed as a hyperlink, so when you click on it, you're taken to the wrong url, which is quite an inconvenient experience. I've created a PR to fix this.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jun 30, 2024
Copy link

boring-cyborg bot commented Jun 30, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@potiuk
Copy link
Member

potiuk commented Jun 30, 2024

The regexp is a bit magic, but it does the job :)

@potiuk
Copy link
Member

potiuk commented Jun 30, 2024

Need static checks fix though (recommend installing pre-commit)

@smlee729
Copy link
Contributor Author

Thanks @potiuk . I found the failing test was successful :

> pre-commit run --hook-stage manual trailing-whitespace --all-files --verbose
Remove trailing whitespace at end of line................................Passed
- hook id: trailing-whitespace
- duration: 0.37s

And pushed a commit. Could you guide me how to re-trigger static-check?

@potiuk
Copy link
Member

potiuk commented Jul 1, 2024

As this is your first contribution, maintainer has to approve and run your workflow (I just did)

@potiuk
Copy link
Member

potiuk commented Jul 1, 2024

Still some checks are failing. Installing pre-commit and running git commit - -amend should fix all the static checks

@smlee729
Copy link
Contributor Author

smlee729 commented Jul 1, 2024

I tried to run pre-commit run --all-files command, but stuck with this phase :

Run mypy for providers.............................................................Failed
- hook id: mypy-providers
- exit code: 2

Using 'uv' to install Airflow


Using airflow version from current sources


Leaving default pydantic v2


Using 'uv' to install Airflow

airflow/providers/fab/auth_manager/cli_commands/user_command.py:215: error:
f-string expression part cannot include a backslash  [syntax]
            print(f"Created the following users:\n\t{'\\n\\t'.join(users_c...
                   ^
Found 1 error in 1 file (errors prevented further checking)
Error 2 returned
If you see strange stacktraces above, and can't reproduce it, please run this command and try again:

breeze ci-image build --python 3.8

You can also run `breeze down --cleanup-mypy-cache` to clean up the cache used.

But since the change is not related to my change, I'm not sure how I can fix this issue..
Could you help me how to fix this?
Other than that, I removed unused variable on my test since it complaints with ESLint.

@smlee729
Copy link
Contributor Author

smlee729 commented Jul 1, 2024

Finally passed :) Yay~

@potiuk potiuk merged commit 2f9b23d into apache:main Jul 2, 2024
49 checks passed
Copy link

boring-cyborg bot commented Jul 2, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@potiuk
Copy link
Member

potiuk commented Jul 2, 2024

🎉

@smlee729 smlee729 deleted the url-regex branch July 2, 2024 21:10
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Jul 12, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow 2.9.3 milestone Jul 12, 2024
utkarsharma2 pushed a commit that referenced this pull request Jul 12, 2024
---------

Co-authored-by: Jacob Lee <[email protected]>
(cherry picked from commit 2f9b23d)
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants