-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken stat scheduler_loop_duration #42886
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
@howardyoo - I'd appreciate if you can review as well, since this follows up on your original PR #40802 |
Thanks, I’ll take a look!Sent from my iPhoneOn Oct 10, 2024, at 2:09 AM, Venkat VJ ***@***.***> wrote:
@howardyoo - Would appreciate if you can review as well, since this follows up on your original PR #40802
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I approved the run - @howardyoo, would be great to get the review. Also - if we could have some unit test for that (can we?) it would be great. |
I don't think this can be unit-tested..? |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* wip * wip * fix lint err --------- Co-authored-by: venkat <[email protected]>
* wip * wip * fix lint err --------- Co-authored-by: venkat <[email protected]>
No. Not unless 2.10.3 rc1 is cancelled and we attempt to do 2.10.3rc2 (cc: @utkarsharma2 @ephraimbuddy ) -> I marked it provisionally for 2.10.4 - next time it's a good idea to mention it before we prepare a new release, that things are good candidates and would be great to back-port. |
I see, thanks @potiuk |
* wip * wip * fix lint err --------- Co-authored-by: venkat <[email protected]> (cherry picked from commit 60b8056)
We are going to have rc2 - > backporting that one in #43544 |
* wip * wip * fix lint err --------- Co-authored-by: venkat <[email protected]> (cherry picked from commit 60b8056) Co-authored-by: Venkat VJ <[email protected]>
* wip * wip * fix lint err --------- Co-authored-by: venkat <[email protected]> (cherry picked from commit 60b8056) Co-authored-by: Venkat VJ <[email protected]> (cherry picked from commit 842c60a)
* wip * wip * fix lint err --------- Co-authored-by: venkat <[email protected]> (cherry picked from commit 60b8056) Co-authored-by: Venkat VJ <[email protected]> (cherry picked from commit 842c60a)
* wip * wip * fix lint err --------- Co-authored-by: venkat <[email protected]> (cherry picked from commit 60b8056) Co-authored-by: Venkat VJ <[email protected]> (cherry picked from commit 842c60a)
* wip * wip * fix lint err --------- Co-authored-by: venkat <[email protected]> (cherry picked from commit 60b8056) Co-authored-by: Venkat VJ <[email protected]> (cherry picked from commit 842c60a)
* wip * wip * fix lint err --------- Co-authored-by: venkat <[email protected]>
The stat
scheduler_loop_duration
is broken since this change. The nesting of the stats context statement results in it not capturing the full scheduler loop duration. This PR fixes the nesting.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.