Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling masking of values of set variable #43123

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

shubhamraj-git
Copy link
Contributor

Better handling masking of values of set variable

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@shubhamraj-git shubhamraj-git force-pushed the mask-issue branch 3 times, most recently from f5370e2 to 2ca34f1 Compare October 17, 2024 15:42
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @shubhamraj-git
I have a few comments

@amoghrajesh
Copy link
Contributor

Test failures look unrelated, but the static checks needs fixing.
@shubhamraj-git you need to set up precommit and use it for your commits. Check: https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a nit, preemptive approval assuming the change will be made +1
The test failure looks to be unrelated, retriggering.

@potiuk potiuk merged commit 1260d9c into apache:main Oct 22, 2024
82 checks passed
@potiuk potiuk added this to the Airflow 2.10.3 milestone Oct 22, 2024
potiuk pushed a commit to potiuk/airflow that referenced this pull request Oct 22, 2024
potiuk added a commit that referenced this pull request Oct 23, 2024
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Oct 23, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 23, 2024
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants