Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fetching XCom with forward slash from the API and escape it in the UI #45134

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

shahar1
Copy link
Contributor

@shahar1 shahar1 commented Dec 21, 2024

closes: #41598


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@shahar1 shahar1 requested a review from BasPH December 21, 2024 16:14
@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Dec 21, 2024
@shahar1 shahar1 added backport-to-v2-10-test Mark PR with this label to backport to v2-10-test branch legacy ui Whether legacy UI change should be allowed in PR legacy api Whether legacy API changes should be allowed in PR labels Dec 21, 2024
@shahar1 shahar1 requested a review from eladkal December 21, 2024 16:20
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport to v2-10-test as well?

@potiuk
Copy link
Member

potiuk commented Dec 21, 2024

Backport to v2-10-test as well?

It's already marked to be backported :)

@potiuk potiuk added this to the Airflow 2.10.5 milestone Dec 21, 2024
@potiuk
Copy link
Member

potiuk commented Dec 21, 2024

(but yes milestone was missing).

@potiuk potiuk merged commit 9316ed6 into apache:main Dec 21, 2024
64 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 21, 2024
…escape it in the UI (#45134)

(cherry picked from commit 9316ed6)

Co-authored-by: Shahar Epstein <[email protected]>
Copy link

Backport successfully created: v2-10-test

Status Branch Result
v2-10-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Dec 21, 2024
…escape it in the UI (apache#45134)

(cherry picked from commit 9316ed6)

Co-authored-by: Shahar Epstein <[email protected]>
potiuk pushed a commit that referenced this pull request Dec 21, 2024
…escape it in the UI (#45134) (#45137)

(cherry picked from commit 9316ed6)

Co-authored-by: Shahar Epstein <[email protected]>
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Jan 6, 2025
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Jan 28, 2025
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues backport-to-v2-10-test Mark PR with this label to backport to v2-10-test branch legacy api Whether legacy API changes should be allowed in PR legacy ui Whether legacy UI change should be allowed in PR type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XCom with / in key results in UI error
4 participants