Replacing deprecated docker-client with docker-java #922
Conversation
| client.pull(image) | ||
| client | ||
| .pullImageCmd(image) | ||
| .start() | ||
| } catch { | ||
| case NonFatal(_) => | ||
| log.warning(s"Failed to pull docker image [$image], is docker running?") | ||
| return | ||
| } |
There was a problem hiding this comment.
Do we need to close the client in finally block？
There was a problem hiding this comment.
Adding a finally block here would close the connection pool of the client before executing the subsequent instruction. I proceeded by adding the client.close() instruction in the afterTermination() override
actor-tests/src/test/scala/org/apache/pekko/io/dns/DockerBindDnsService.scala
Show resolved
Hide resolved
actor-tests/src/test/scala/org/apache/pekko/io/dns/DockerBindDnsService.scala
Show resolved
Hide resolved
|
|
||
| abstract class DockerBindDnsService(config: Config) extends PekkoSpec(config) with Eventually { | ||
| val client = DefaultDockerClient.fromEnv().build() | ||
|
|
||
| val dockerConfig: DockerClientConfig = DefaultDockerClientConfig.createDefaultConfigBuilder().build(); |
There was a problem hiding this comment.
DefaultDockerClient.fromEnv() -> DefaultDockerClientConfig.createDefaultConfigBuilder()
This change seems to bring some changes to the configuration method, it can't configration by env.
DockerClientConfig custom = DefaultDockerClientConfig.createDefaultConfigBuilder()
.withDockerHost("tcp://docker.somewhere.tld:2376")
.withDockerTlsVerify(true)
.withDockerCertPath("/home/user/.docker")
.withRegistryUsername(registryUser)
.withRegistryPassword(registryPass)
.withRegistryEmail(registryMail)
.withRegistryUrl(registryUrl)
.build();for testContainer, we can configration by env
https://java.testcontainers.org/supported_docker_environment/
please consider the question: How can I customize the Docker configuration,
maybe docker-java supportes it allready.
There was a problem hiding this comment.
@laglangyue from my understanding the createDefaultConfigBuilder fetch the configuration from env, unless overwritten, see: https://github.com/docker-java/docker-java/blob/main/docs/getting_started.md#system-environment
Please let me know if I am missing something
There was a problem hiding this comment.
Maybe it is necessary to add a document or a link to tell users how to configure it.
|
Both |
samueleresca
force-pushed
the
replacing-docker-client
branch
from
6dd9502 to
19e0776
Compare
Now the tests are passing - the code wasn't awaiting for the |
|
LGTM |
* Replacing deprecated docker-client with docker-java. * Addressing feedback. * Awaiting for image pull. --------- Co-authored-by: Samuele Resca <[email protected]>
* Replacing deprecated docker-client with docker-java. * Addressing feedback. * Awaiting for image pull. --------- Co-authored-by: Samuele Resca <[email protected]>
Changes
Replacing deprecated docker-client with docker-java. See: #806
Testing
AsyncDnsResolverIntegrationSpecandDnsDiscoverySpectests are successful.