[MINOR][INFRA] Do not upload docker build record #48012
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Yikun FYI |
|
Here is a run with #48011 only: Here is a run with #48011 and this fix applied: |
HyukjinKwon
changed the title
HyukjinKwon
pushed a commit
that referenced
this pull request
Sep 6, 2024
### What changes were proposed in this pull request? Upgrade `dawidd6/action-download-artifact` from v1 to v6 Upgrade `scacap/action-surefire-report` from v1.0.13 to v1.8.0 ### Why are the changes needed? Current versions have the following problems: `dawidd6/action-download-artifact` failing: ``` ==> Downloading: apache~spark~ADIBKZ.dockerbuild.zip (44.7 kB) Error: <?xml version="1.0" encoding="utf-8"?> <Error><Code>AuthenticationFailed</Code><Message>Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature. RequestId:2c8b19f5-601e-007f-54e7-ffac7a000000 Time:2024-09-05T23:01:54.1979479Z</Message></Error> ``` https://github.com/apache/spark/actions/runs/10729437729/job/29756039009#step:2:15-17 `scacap/action-surefire-report` warning: ``` Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ ``` https://github.com/apache/spark/actions/runs/10723482700/job/29736875911#step:3:14 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? In GitHub CI: The download succeeds (authentication issue above resolved), not hit by another bug: docker/build-push-action#1167 ``` ==> Downloading: G-Research~spark~R7TXVG.dockerbuild.zip (23.76 kB) Error: Invalid or unsupported zip format. No END header found ``` https://github.com/G-Research/spark/actions/runs/10733657395/job/29767392437#step:2:27 To be fixed in #48012. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48011 from EnricoMi/master. Authored-by: Enrico Minack <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
IvanK-db
pushed a commit
to IvanK-db/spark
that referenced
this pull request
Sep 20, 2024
### What changes were proposed in this pull request? Upgrade `dawidd6/action-download-artifact` from v1 to v6 Upgrade `scacap/action-surefire-report` from v1.0.13 to v1.8.0 ### Why are the changes needed? Current versions have the following problems: `dawidd6/action-download-artifact` failing: ``` ==> Downloading: apache~spark~ADIBKZ.dockerbuild.zip (44.7 kB) Error: <?xml version="1.0" encoding="utf-8"?> <Error><Code>AuthenticationFailed</Code><Message>Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature. RequestId:2c8b19f5-601e-007f-54e7-ffac7a000000 Time:2024-09-05T23:01:54.1979479Z</Message></Error> ``` https://github.com/apache/spark/actions/runs/10729437729/job/29756039009#step:2:15-17 `scacap/action-surefire-report` warning: ``` Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ ``` https://github.com/apache/spark/actions/runs/10723482700/job/29736875911#step:3:14 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? In GitHub CI: The download succeeds (authentication issue above resolved), not hit by another bug: docker/build-push-action#1167 ``` ==> Downloading: G-Research~spark~R7TXVG.dockerbuild.zip (23.76 kB) Error: Invalid or unsupported zip format. No END header found ``` https://github.com/G-Research/spark/actions/runs/10733657395/job/29767392437#step:2:27 To be fixed in apache#48012. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48011 from EnricoMi/master. Authored-by: Enrico Minack <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? Upgrade `dawidd6/action-download-artifact` from v1 to v6 Upgrade `scacap/action-surefire-report` from v1.0.13 to v1.8.0 ### Why are the changes needed? Current versions have the following problems: `dawidd6/action-download-artifact` failing: ``` ==> Downloading: apache~spark~ADIBKZ.dockerbuild.zip (44.7 kB) Error: <?xml version="1.0" encoding="utf-8"?> <Error><Code>AuthenticationFailed</Code><Message>Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature. RequestId:2c8b19f5-601e-007f-54e7-ffac7a000000 Time:2024-09-05T23:01:54.1979479Z</Message></Error> ``` https://github.com/apache/spark/actions/runs/10729437729/job/29756039009#step:2:15-17 `scacap/action-surefire-report` warning: ``` Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ ``` https://github.com/apache/spark/actions/runs/10723482700/job/29736875911#step:3:14 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? In GitHub CI: The download succeeds (authentication issue above resolved), not hit by another bug: docker/build-push-action#1167 ``` ==> Downloading: G-Research~spark~R7TXVG.dockerbuild.zip (23.76 kB) Error: Invalid or unsupported zip format. No END header found ``` https://github.com/G-Research/spark/actions/runs/10733657395/job/29767392437#step:2:27 To be fixed in apache#48012. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48011 from EnricoMi/master. Authored-by: Enrico Minack <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
|
Current spark job doesn't depends on docker build record, so it's safe. Any other steps should be also be changed? If not, LGTM. |
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? Upgrade `dawidd6/action-download-artifact` from v1 to v6 Upgrade `scacap/action-surefire-report` from v1.0.13 to v1.8.0 ### Why are the changes needed? Current versions have the following problems: `dawidd6/action-download-artifact` failing: ``` ==> Downloading: apache~spark~ADIBKZ.dockerbuild.zip (44.7 kB) Error: <?xml version="1.0" encoding="utf-8"?> <Error><Code>AuthenticationFailed</Code><Message>Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature. RequestId:2c8b19f5-601e-007f-54e7-ffac7a000000 Time:2024-09-05T23:01:54.1979479Z</Message></Error> ``` https://github.com/apache/spark/actions/runs/10729437729/job/29756039009#step:2:15-17 `scacap/action-surefire-report` warning: ``` Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ ``` https://github.com/apache/spark/actions/runs/10723482700/job/29736875911#step:3:14 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? In GitHub CI: The download succeeds (authentication issue above resolved), not hit by another bug: docker/build-push-action#1167 ``` ==> Downloading: G-Research~spark~R7TXVG.dockerbuild.zip (23.76 kB) Error: Invalid or unsupported zip format. No END header found ``` https://github.com/G-Research/spark/actions/runs/10733657395/job/29767392437#step:2:27 To be fixed in apache#48012. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48011 from EnricoMi/master. Authored-by: Enrico Minack <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
EnricoMi
force-pushed
the
ci-do-not-upload-dockerbuild
branch
from
a65dc23 to
af3d8ce
Compare
|
@Yikun moved the env from step to workflow level so it applies to all steps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make
docker/build-push-actionaction not upload the docker build record.Why are the changes needed?
The way
docker/build-push-actionuploads the file breaks actiondawidd6/action-download-artifact, which breaks thetest_report.yamlworkflow that publishes test results.https://github.com/G-Research/spark/actions/runs/10733657395/job/29767392437#step:2:27-27
See docker/build-push-action#1167.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested in GitHub CI.
Was this patch authored or co-authored using generative AI tooling?
No.