Use docker/login-action rather than aws-actions/amazon-ecr-login #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
.github/workflows/build-image.yml
Outdated
| @@ -43,7 +43,9 @@ jobs: | |||
| role-to-assume: ${{ secrets.IAM_ROLE }} | |||
| aws-region: ap-northeast-1 | |||
| - name: Login to Amazon ECR | |||
| uses: aws-actions/amazon-ecr-login@v1 | |||
| uses: docker/login-action@v1 | |||
| with: | |||
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
could not parse as YAML: yaml: line 47: mapping values are not allowed in this context [yaml-syntax]
KOBA789
reviewed
Apr 19, 2022
KOBA789
changed the title
Yoshiki-Iwasa
force-pushed
the
fix/replace-aws-actions/amazon-ecr-login
branch
from
5965ddd to
3ff1184
Compare
Yoshiki-Iwasa
force-pushed
the
fix/replace-aws-actions/amazon-ecr-login
branch
from
3ff1184 to
23766b5
Compare
sksat
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
docker/login-actionbecauseaws-actions/amazon-ecr-loginseems not to be updated.